Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows installer PATH #267

Closed
andrejohansson opened this issue Oct 5, 2021 · 2 comments · Fixed by #276 or #281
Closed

Fix Windows installer PATH #267

andrejohansson opened this issue Oct 5, 2021 · 2 comments · Fixed by #276 or #281
Assignees
@lepapareil
Labels
bug Something isn't working windows
Milestone
1.4.0

Comments

@andrejohansson
Copy link

andrejohansson commented Oct 5, 2021 •
edited

After installing my PATH variable was emptied to contain only "c:\program files\hurl" and all my previous entries were removed. This can cause some serious headache on a developer machine.

NOTE: I do have a very long path (2k+) which can be of interest.

TIP: To restore your path https://superuser.com/questions/523688/how-to-restore-the-path-environment-variable-i-deleted
@lepapareil lepapareil self-assigned this Oct 5, 2021
@lepapareil lepapareil added the bug Something isn't working label Oct 5, 2021
@lepapareil
Copy link
Collaborator

lepapareil commented Oct 5, 2021 •
edited

Thanks for reporting this bug and really sorry for the inconvenience 😢

The root cause is due to the fact that we use NSIS to create the windows installer and more precisely its read/write registry functions, but these depend on the NSIS_MAX_STRLEN var which is effectively limited to 1024 bytes. We have updated hurl install documentation to warn users about this issue and should use EnVar_plug-in for the next hurl 1.4 release.

@lepapareil lepapareil added this to the 1.4.0 milestone Oct 5, 2021
@lepapareil lepapareil added 1.4.0 and removed 1.4.0 labels Oct 5, 2021
@jcamiel jcamiel added the 1.4.0 label Oct 5, 2021
@jcamiel jcamiel removed this from the 1.4.0 milestone Oct 5, 2021
@lepapareil lepapareil added this to the 1.4.0 milestone Oct 6, 2021
lepapareil added a commit that referenced this issue Oct 7, 2021
@lepapareil
#267 fix windows installer emptying user Path variable
5ea8f02
fabricereix pushed a commit that referenced this issue Oct 7, 2021
@lepapareil @fabricereix
#267 fix windows installer emptying user Path variable
215b0f4
@fabricereix fabricereix linked a pull request Oct 7, 2021 that will close this issue
#267 fix windows installer emptying user Path variable #276
Merged
lepapareil added a commit that referenced this issue Oct 8, 2021
@lepapareil
optimize windows installer #267
bff7624
@lepapareil lepapareil linked a pull request Oct 8, 2021 that will close this issue
optimize windows installer #267 #281
Merged
fabricereix pushed a commit that referenced this issue Oct 8, 2021
@lepapareil @fabricereix
optimize windows installer #267
88c5338
fabricereix pushed a commit that referenced this issue Oct 8, 2021
@lepapareil @fabricereix
optimize windows installer #267
dab4006
@lepapareil
Copy link
Collaborator

lepapareil commented Oct 8, 2021 •
edited

Hi @andrejohansson, feel free to pre-test this fix using 1.4.0-snapshot new windows installer 👍

@fabricereix fabricereix changed the title Windows installer deleted my PATH Fix Windows installer PATH Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lepapareil lepapareil

Labels
bug Something isn't working windows
Projects
None yet
Milestone
1.4.0
3 participants
@andrejohansson @lepapareil @jcamiel