Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move error_string to DisplaySourceError #2956

Merged
merged 1 commit into from
Jun 30, 2024
Merged

Move error_string to DisplaySourceError #2956

merged 1 commit into from
Jun 30, 2024

Conversation

fabricereix
Copy link
Collaborator

No description provided.

@fabricereix fabricereix force-pushed the refacto/move-error-string-to-displaysourceerror-trait branch 3 times, most recently from aedd2f5 to 2534a42 Compare June 27, 2024 21:22
@jcamiel
Copy link
Collaborator

jcamiel commented Jun 28, 2024

/rebase

@hurl-bot
Copy link
Collaborator

🕗 /rebase is running, please wait for completion.

@hurl-bot
Copy link
Collaborator

🔨 Auto rebase from Orange-OpenSource/hurl/master succeeds, Orange-OpenSource/hurl/refacto/move-error-string-to-displaysourceerror-trait now embeds these commits:

  • d026280 Rename jsonpath::parser::error::Error to jsonpath::parser::error::ParseError
  • da4792b Remove try_literal method from JSONPath reader.
  • e8355a7 Extract reader from parser module.
  • 257e9a8 Change param filters type to slice in eval_filters.
  • c7bcd70 Update crates

@hurl-bot hurl-bot force-pushed the refacto/move-error-string-to-displaysourceerror-trait branch from 2534a42 to 6dd45f7 Compare June 28, 2024 14:49
@jcamiel jcamiel force-pushed the refacto/move-error-string-to-displaysourceerror-trait branch 4 times, most recently from d4401d5 to 7c30f20 Compare June 28, 2024 16:51
@fabricereix fabricereix force-pushed the refacto/move-error-string-to-displaysourceerror-trait branch 2 times, most recently from 2d66a58 to 947cf66 Compare June 29, 2024 20:59
@jcamiel
Copy link
Collaborator

jcamiel commented Jun 30, 2024

/accept

@hurl-bot
Copy link
Collaborator

🕗 /accept is running, please wait for completion.

@hurl-bot
Copy link
Collaborator

❌ New commits have been pushed to Orange-OpenSource/hurl/master since you accept this PR. You can rebase it by yourself or simply re-accept this PR to execute an auto rebase.
Pending commits:

@jcamiel
Copy link
Collaborator

jcamiel commented Jun 30, 2024

/accept

@hurl-bot
Copy link
Collaborator

🕗 /accept is running, please wait for completion.

@hurl-bot
Copy link
Collaborator

🔨 Auto rebase from Orange-OpenSource/hurl/master succeeds, Orange-OpenSource/hurl/refacto/move-error-string-to-displaysourceerror-trait now embeds these commits:

@hurl-bot
Copy link
Collaborator

🕗 /accept is still running, please wait for completion.

@hurl-bot hurl-bot force-pushed the refacto/move-error-string-to-displaysourceerror-trait branch from 947cf66 to c49a89d Compare June 30, 2024 08:42
@hurl-bot
Copy link
Collaborator

✅ Pull request merged and closed by jcamiel with fast forward merge..

# List of commits merged from Orange-OpenSource/hurl/refacto/move-error-string-to-displaysourceerror-trait branch into Orange-OpenSource/hurl/master branch:

  • c49a89d Move error_string to DisplaySourceError to_string

@hurl-bot hurl-bot merged commit c49a89d into master Jun 30, 2024
22 checks passed
@hurl-bot hurl-bot deleted the refacto/move-error-string-to-displaysourceerror-trait branch June 30, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcamiel jcamiel jcamiel left review comments

Assignees

@jcamiel jcamiel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabricereix @jcamiel @hurl-bot