This repository has been archived by the owner on Oct 20, 2022. It is now read-only.
feat: optionally remove flow.xml on startup #207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 9, 2022 14:03
feat: removeFlowFileOnStartup option Signed-off-by: Gene Hynson <ghynson@influxdata.com>
Signed-off-by: Gene Hynson <ghynson@influxdata.com>
Signed-off-by: Gene Hynson <ghynson@influxdata.com>
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR adds the property
RemoveFlowFileOnStartupwhich defaults totrueand matches the existing behavior. Changing this flag tofalsekeeps theflow.xml.gzfile on disk when starting the pod.Why?
Some users do not want the flow.xml.gz file to be removed every time the pod is restarted because all flows have to be recreated. NiFi supports consuming an existing flow.xml.gz file on startup and will recreate all the persisted flows as long as the sensitive props key is the same. This is mainly to support a single node deployment. In a multi-node environment, removing the flow.xml.gz file is necessary for rolling updates to succeed. However, for users who are happy with a single node deployment and are using a PV for the flow.xml.gz file, this feature is useful.
Default behavior is unchanged from the current implementation. This new property is not required.
Checklist