728 - Allow leading icon on OdsPasswordTextField #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecurity-fix-strandhogg-vulnerability 463 - Fix security vulnerability
…zation preview with optional leading icon
✅ Deploy Preview for ods-android ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @LaurentRenard, we saw your PR however your request requires validation from the design team. @mccart77, could you tell us if adding a leading icon in a password text field is something that we can consider? |
|
Hi @LaurentRenard, can we discuss the options you would like to consider, perhaps we can do this via Friends of ODS on Teams. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to add an optional leading icon to OdsPasswordTextField, similarly to OdsTextField
Without this, it is not possible to implement a properly balanced basic login form (user/password) where both fields should present a leading icon