Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add analytics #136

Merged

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Feb 20, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Closes #130.
Closes #15.

Description

  • Added the cookies management using TarteAuCitron
  • Added the custom scripts and custom CSS

Should we add a page to manage cookies ? If yes where is the link to it ?
It's quite dirty rn, since it's pure html. The example part is hardcoded but the api part is implemented via build/tarteaucitron.html which is minified. Should it be unminifed ?

Motivation & Context

Make sure the analytics are made somewhere.

Types of change

  • New feature (non-breaking change which adds functionality)

Test checklist

Please check that the following tests projects are still working:

  • docs/examples
  • test/angular-ngx-echarts
  • test/angular-echarts
  • test/html
  • test/react
  • test/vue
  • test/examples/bar-line-chart
  • test/examples/single-line-chart
  • test/examples/timeseries-chart

Copy link

netlify bot commented Feb 20, 2024

Deploy Preview for ods-charts ready!

Name Link
🔨 Latest commit 949abe4
🔍 Latest deploy log https://app.netlify.com/sites/ods-charts/deploys/6606c973b8ba7100087b7d69
😎 Deploy Preview https://deploy-preview-136--ods-charts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@louismaximepiton louismaximepiton marked this pull request as ready for review February 20, 2024 14:30
@julien-deramond julien-deramond added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 21, 2024
@julien-deramond

This comment was marked as resolved.

@julien-deramond julien-deramond marked this pull request as draft March 22, 2024 06:51
build/add_head.mjs Outdated Show resolved Hide resolved
build/add_head.mjs Outdated Show resolved Hide resolved
@louismaximepiton louismaximepiton marked this pull request as ready for review March 26, 2024 08:38
build/add_head.mjs Outdated Show resolved Hide resolved
@julien-deramond
Copy link
Member

Should we add a page to manage cookies ? If yes where is the link to it ?

We should, but for that we'd probably need to integrate a footer. I let you create another issue to tackle it later on.

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@julien-deramond julien-deramond merged commit 2a70645 into Orange-OpenSource:main Mar 29, 2024
4 checks passed
@louismaximepiton louismaximepiton deleted the main-lmp-add-analytics branch March 29, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc: Add analytics Add a favicon to the documentation
2 participants