Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump echarts from 5.4.3 to 5.5.0 in the lib and test… #141

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Feb 21, 2024

Description

This PR supersedes #140 which is not complete.

This PR bumps echarts version from 5.4.3 to 5.5.0 for the ODS Charts library, but also for all test projects (in their package.json or CDN versions).

As mentioned by @louismaximepiton in #140 (comment), appendToBody is now deprecated, so this PR now uses appendTo: 'body' instead. This is not that important right now as our library is in alpha. But in the future, we need to think about it precisely as our library would be compatible only from v5.5.0.

Please note that their change to ESM default package doesn't seem to impact us.

… projects

Bumps [echarts](https://github.com/apache/echarts) from 5.4.3 to 5.5.0.
- [Release notes](https://github.com/apache/echarts/releases)
- [Commits](apache/echarts@5.4.3...5.5.0)

---
updated-dependencies:
- dependency-name: echarts
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@julien-deramond julien-deramond added the dependencies Pull requests that update a dependency file label Feb 21, 2024
Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for ods-charts ready!

Name Link
🔨 Latest commit bed2e9e
🔍 Latest deploy log https://app.netlify.com/sites/ods-charts/deploys/65d5fbde0efa7c0008a4205d
😎 Deploy Preview https://deploy-preview-141--ods-charts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond merged commit a2dfeee into main Feb 21, 2024
4 checks passed
@julien-deramond julien-deramond deleted the main-jd-bump-echarts-to-5.5.0 branch February 21, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file library test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant