Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tooltipConfine option #147

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Mar 1, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Closes #146.

Description

Remove useless tooltipConfine.

Motivation & Context

There was an issue using this new option in #107 and there is no need for it anymore after the patch.
Sorry for the issue.

Types of change

  • Bug fix (breaking which fixes an issue)

Copy link

netlify bot commented Mar 1, 2024

Deploy Preview for ods-charts ready!

Name Link
🔨 Latest commit 335d194
🔍 Latest deploy log https://app.netlify.com/sites/ods-charts/deploys/65e1f90e263536000863773c
😎 Deploy Preview https://deploy-preview-147--ods-charts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jacques-lebourgeois
Copy link
Member

I have a look at it

@jacques-lebourgeois
Copy link
Member

Do you think we could keep tooltipConfine like another available option ?

@julien-deramond julien-deramond added enhancement New feature or request library labels Mar 8, 2024
@julien-deramond julien-deramond merged commit 8b372b9 into Orange-OpenSource:main Mar 8, 2024
4 checks passed
@louismaximepiton louismaximepiton deleted the main-lmp-remove-tooltip-confine branch March 8, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tooltipConfine: Issue with tooltip.confine
3 participants