Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A solution for displaying a series with two colours #92 #161

Merged

Conversation

jacques-lebourgeois
Copy link
Member

Here's a solution that doesn't change the library but requires two series to be produced depending on whether or not the objective is achieved

@jacques-lebourgeois jacques-lebourgeois linked an issue Mar 15, 2024 that may be closed by this pull request
2 tasks
Copy link

netlify bot commented Mar 15, 2024

Deploy Preview for ods-charts ready!

Name Link
🔨 Latest commit a8e8bdc
🔍 Latest deploy log https://app.netlify.com/sites/ods-charts/deploys/65fc1f2d79d8b70008d53042
😎 Deploy Preview https://deploy-preview-161--ods-charts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this use case

@julien-deramond

This comment was marked as resolved.

@jacques-lebourgeois
Copy link
Member Author

A complement : we probably should use colors from libs and not custom colors in this example

@julien-deramond

This comment was marked as resolved.

@julien-deramond julien-deramond added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 21, 2024
@julien-deramond julien-deramond self-requested a review March 21, 2024 11:51
@julien-deramond julien-deramond merged commit c8cb3be into main Mar 21, 2024
4 checks passed
@julien-deramond julien-deramond deleted the 92-a-solution-for-displaying-a-series-with-two-colours branch March 21, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A solution for displaying a series with two colours
3 participants