Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib): 'COMON' → 'COMMON' typo in theme const vars #33

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

julien-deramond
Copy link
Member

Description

This PR fixes a typo found in a const variable used in the library. It shouldn't have any impacts on the usage for now and might need to republish soon an alpha version of the library.

Types of change

  • Bug fix (non-breaking which fixes an issue)

Test checklist

Please check that the following tests projects are still working:

  • docs/examples
  • test/angular-ngx-echarts
  • test/angular-tour-of-heroes
  • test/html
  • test/react
  • test/vue
  • test/examples/bar-line-chart
  • test/examples/single-line-chart

Copy link

netlify bot commented Dec 1, 2023

Deploy Preview for ods-charts ready!

Name Link
🔨 Latest commit 1b6e339
🔍 Latest deploy log https://app.netlify.com/sites/ods-charts/deploys/656a15acb0fde80008c4b761
😎 Deploy Preview https://deploy-preview-33--ods-charts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond changed the title fix(lib): 'COMON' -> 'COMMON' typo in theme const vars fix(lib): 'COMON' → 'COMMON' typo in theme const vars Dec 1, 2023
@julien-deramond julien-deramond merged commit 078a3f3 into main Dec 2, 2023
4 checks passed
@julien-deramond julien-deramond deleted the main-jd-fix-COMON-typo branch December 2, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants