Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib): 'ODSCHarts*' → 'ODSCharts*' typo #35

Merged
merged 2 commits into from
Dec 3, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Dec 3, 2023

Description

This PR simply fixes the following typo: 'ODSCHarts*' → 'ODSCharts*'.
It has an impact on the library's usage so we should release a new alpha.

During the review, please double-check that the examples are still working and that the API documentation is modified accordingly.

Types of change

  • Bug fix (non-breaking which fixes an issue)

Test checklist

Please check that the following tests projects are still working:

  • docs/examples
  • test/angular-ngx-echarts
  • test/angular-tour-of-heroes
  • test/html
  • test/react
  • test/vue
  • test/examples/bar-line-chart
  • test/examples/single-line-chart

Copy link

netlify bot commented Dec 3, 2023

Deploy Preview for ods-charts ready!

Name Link
🔨 Latest commit 50600f0
🔍 Latest deploy log https://app.netlify.com/sites/ods-charts/deploys/656c94099fc88a0008f366d6
😎 Deploy Preview https://deploy-preview-35--ods-charts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond added documentation Improvements or additions to documentation library labels Dec 3, 2023
@julien-deramond julien-deramond merged commit 146ec9c into main Dec 3, 2023
4 checks passed
@julien-deramond julien-deramond deleted the main-jd-typo-ODSCHarts branch December 3, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation fix library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant