Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Add a class to enhance popover fluidity on hover #69

Conversation

louismaximepiton
Copy link
Member

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

NA

Description

Adding .pe-none to the popovers.
Adding pointer-events: none !important to the popovers for angular at least.

Motivation & Context

It was quite unpleasant to browse the examples and moving the mouse towards the top of the page because it places the cursor over the popover and prevent new popovers to create.

Types of change

  • Bug fix (non-breaking which fixes an issue)

Test checklist

Please check that the following tests projects are still working:

  • docs/examples
  • test/angular-ngx-echarts
  • test/angular-tour-of-heroes
  • test/html
  • test/react
  • test/vue
  • test/examples/bar-line-chart
  • test/examples/single-line-chart
  • test/examples/timeseries-chart

Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for ods-charts ready!

Name Link
🔨 Latest commit 244d94b
🔍 Latest deploy log https://app.netlify.com/sites/ods-charts/deploys/65b9ed6189291b0008927c5f
😎 Deploy Preview https://deploy-preview-69--ods-charts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond added enhancement New feature or request library labels Jan 31, 2024
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Modification really appreciated!
Tried it in the all examples and it works perfectly! LGTM

@julien-deramond julien-deramond merged commit f3cea82 into Orange-OpenSource:main Jan 31, 2024
4 checks passed
@louismaximepiton louismaximepiton deleted the main-lmp-popover-fluidity branch January 31, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants