Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test sprite loading #14

Closed
Yeffian opened this issue May 2, 2022 · 1 comment · Fixed by #22
Closed

Test sprite loading #14

Yeffian opened this issue May 2, 2022 · 1 comment · Fixed by #22
Labels
bug Something isn't working hacktoberfest help wanted Extra attention is needed

Comments

@Yeffian
Copy link
Member

Yeffian commented May 2, 2022

In the unit tests for the component system, the test which tests building a game object with a sprite fails is ignored because of a JVM crash.

Unit test:
https://github.com/OrbitalEngine/Orbital/blob/master/src/test/java/dev/yeff/orbital/tests/ecs/GameObjectTests.java#L108
Yeffian added a commit that referenced this issue Sep 14, 2022
@Yeffian
comment out sprite test (#14)
0457f2b
@Yeffian
Copy link
Member Author

Yeffian commented Oct 2, 2022

This crash occurs because Raylib does not let you load sprites before you initialize a window. Now we need to figure out how to rewrite the unit test.

@Yeffian Yeffian added bug Something isn't working help wanted Extra attention is needed hacktoberfest labels Oct 2, 2022
@Yeffian Yeffian changed the title Fix JVM crash in component system unit tests Test sprite loading Oct 5, 2022
@1anakin20 1anakin20 mentioned this issue Oct 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test sprite loading failing fix 1anakin20/Orbital
1 participant
@Yeffian