Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorporate semver sorting into package versions #15

Open
rtpHarry opened this issue Feb 3, 2016 · 2 comments
Open

incorporate semver sorting into package versions #15

rtpHarry opened this issue Feb 3, 2016 · 2 comments

Comments

@rtpHarry
Copy link
Contributor

rtpHarry commented Feb 3, 2016

Currently the sorting algorithm trips up when a version is in double digits eg 1.9.0 is considered newer than 1.10.0 because it sees it as 1.9 and 1.1

Need to incorporate the concept of semver sorting. This should provide a good starting point:
@rtpHarry rtpHarry mentioned this issue Feb 3, 2016
Closed
@rtpHarry
Copy link
Contributor Author

rtpHarry commented Feb 5, 2016

I've been catching up on the podcast videos and I see this has been discussed but I still think that the existing casing code should have some special casing added to number sort the last bit, especially if the admin UI has been modified to not allow the build portion of the version to be used for any future packages.

@agriffard
Copy link
Member

Linked to #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@agriffard @rtpHarry