Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored IMachineNameProvider #5813

Closed
wants to merge 0 commits into from
Closed

Refactored IMachineNameProvider #5813

wants to merge 0 commits into from

Conversation

sfmskywalker
Copy link
Member

  • Renamed to IApplicationEnvironment.
  • Added ScriptTimeout property.

@sfmskywalker sfmskywalker mentioned this pull request Sep 15, 2015
Closed
@sebastienros
Copy link
Member

Please target dev.
Please rename GetMAchineName to GetEnvironmentIdentifier and change the default implementation to using the process id. The machine name per se hardly makes sense, and users can still get Environment.MachineName if they really want it. We actually don't want to abstract how to get the machine name, but what physical process is running the code.

@sfmskywalker sfmskywalker force-pushed the issue/5758/configurableexecutiontimeout branch from 488e438 to 66ff5d3 Compare September 15, 2015 21:34
@sfmskywalker sfmskywalker deleted the issue/5758/configurableexecutiontimeout branch September 15, 2015 21:36
@rfcdejong rfcdejong mentioned this pull request Mar 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sfmskywalker @sebastienros @dnfclas