Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCC-3: Add static code analysers and fix the warnings #119

Merged
merged 125 commits into from
Apr 30, 2022
Merged

OCC-3: Add static code analysers and fix the warnings #119

merged 125 commits into from
Apr 30, 2022

Conversation

sarahelsaig
Copy link
Contributor

@sarahelsaig sarahelsaig commented Apr 25, 2022 •
edited by Piedone

Fixes #109
OCC-3

@sarahelsaig
Mini bug fix.
7211324 
(happens when two attributes of the same type are attached)
@sarahelsaig
Add Lombiq.Analyzers.
e4e3b8a
@sarahelsaig
Add solution items.
d060a8f
@sarahelsaig
Update gitignore.
50d9ebc
@sarahelsaig
Use expression body for methods
e776cff
@sarahelsaig
Partial class with single part.
a180d63
@sarahelsaig
Use trailing comma in multi-line initializers
7c6106b
@sarahelsaig
Convert to file-scoped namespace
106792b
@sarahelsaig
Auto-fix variable names.
33801ce
@sarahelsaig
Make members readonly.
8dc90d7
@sarahelsaig
Use string.Empty for empty strings
9f30e1e
@sarahelsaig
Closing brace should be followed by blank line
fca5df8
@sarahelsaig
Parameter names should match base declaration
e221022
@sarahelsaig
Use 'new(...)'
cd14169
@sarahelsaig
use 'var' instead of explicit type
c702ec3
@sarahelsaig
Accessibility modifiers required
0e93eb6
@sarahelsaig
Align braces.
f01d685
@sarahelsaig
Fix spacing.
5e9f1ca
@sarahelsaig
Simplify the name 'String'
56472d4
@sarahelsaig
Fix IAddressFormatter.cs.
37e150c
@sarahelsaig
S113 Add a new line at the end of the file.
4f6aa6f
@sarahelsaig
The property's documentation summary text should begin with 'Gets or …
a760464 
…sets' and the like.
@sarahelsaig
The method method does not need to use async/await.
0167054
@sarahelsaig
Using directive is unnecessary.
7876836
@sarahelsaig
Split long lines.
ed4bde9
@sarahelsaig
Add the 'Async' suffix to the name of this method.
cef183c
@sarahelsaig
The parameters should begin on the line after the declaration, whenev…
04a1513 
…er the parameter span across multiple lines
@sarahelsaig
Using directives should be ordered alphabetically by the namespaces
5b0da3e
@sarahelsaig
Documentation text should end with a period.
17e86d1
@sarahelsaig
Constructor must start with standard text.
f457340
0liver
0liver requested changes Apr 29, 2022
View reviewed changes
MoneyDataType/Amount.cs Show resolved Hide resolved
MoneyDataType/Amount.cs Show resolved Hide resolved
OrchardCore.Commerce/Abstractions/IPredefinedValuesProductAttributeService.cs Show resolved Hide resolved
OrchardCore.Commerce/Models/ShoppingCart.cs Outdated Show resolved Hide resolved
OrchardCore.Commerce/Services/ShoppingCartHelpers.cs Show resolved Hide resolved
OrchardCore.Commerce/Views/ProductPart.cshtml Show resolved Hide resolved
OrchardCore.Commerce/Views/ShoppingCart/Index.cshtml Outdated Show resolved Hide resolved
OrchardCore.Commerce/Views/ShoppingCart/Index.cshtml Outdated Show resolved Hide resolved
OrchardCore.Commerce/Views/TextProductAttributeField.cshtml Show resolved Hide resolved
OrchardCore.Commerce/Views/TextProductAttributeField.cshtml Outdated Show resolved Hide resolved
@0liver 0liver merged commit 0bdbe9a into main Apr 30, 2022
@barthamark barthamark mentioned this pull request May 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bleroy bleroy bleroy left review comments

@0liver 0liver 0liver approved these changes

Assignees

@sarahelsaig sarahelsaig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add static code analysers and fix the warnings
3 participants
@sarahelsaig @0liver @bleroy