Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCC-11: Stripe payment integration #127

Merged
merged 87 commits into from
Jul 31, 2022
Merged

OCC-11: Stripe payment integration #127

merged 87 commits into from
Jul 31, 2022

Conversation

DemeSzabolcs
Copy link
Contributor

@DemeSzabolcs DemeSzabolcs commented Jun 27, 2022 •
edited

OCC-11

part of #16

@Skrypt
Copy link
Contributor

Skrypt commented Jun 28, 2022 •
edited

Should it not implement an IPaymentProvider? Just like here :

https://github.com/OrchardCMS/OrchardCore.Commerce/blob/main/src/Modules/OrchardCore.Commerce/Services/CreditCardPaymentProvider.cs

@DemeSzabolcs
Copy link
Contributor Author

Should it not implement an IPaymentProvider? Just like here :

https://github.com/OrchardCMS/OrchardCore.Commerce/blob/main/src/Modules/OrchardCore.Commerce/Services/CreditCardPaymentProvider.cs

I think I can use what you just linked. But it's still WIP I will look into it.

@DemeSzabolcs DemeSzabolcs marked this pull request as draft June 28, 2022 11:08
@sarahelsaig sarahelsaig mentioned this pull request Jul 30, 2022
Closed
This was referenced Jul 31, 2022
Closed
Open
@sarahelsaig
Copy link
Contributor

Looks like I have double masthead on the Order view page:
image

@sarahelsaig sarahelsaig merged commit bcf153c into main Jul 31, 2022
@agriffard
Copy link
Member

Do you plan to make a demo during a weekly meeting?

sarahelsaig
sarahelsaig reviewed Aug 1, 2022
View reviewed changes
README.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skrypt Skrypt Skrypt left review comments

@sarahelsaig sarahelsaig sarahelsaig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DemeSzabolcs @Skrypt @sarahelsaig @agriffard