NEST-319: Upgrade remaining Orchard Core packages to 1.4.0 and fix settings and editor crash when Localization feature is enabled #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DemeSzabolcs
commented
Aug 1, 2022
src/Modules/OrchardCore.Commerce/Settings/CommerceSettingsDisplayDriver.cs
Outdated
Show resolved
Hide resolved
DemeSzabolcs
changed the title
# Conflicts: # src/Modules/OrchardCore.Commerce/OrchardCore.Commerce.csproj
sarahelsaig
requested changes
Aug 2, 2022
src/Modules/OrchardCore.Commerce/Settings/CommerceSettingsDisplayDriver.cs
Outdated
Show resolved
Hide resolved
sarahelsaig
reviewed
Aug 2, 2022
Directory.Build.props
Outdated
Comment on lines
2
to
4
| <PropertyGroup> | ||
| <LombiqHelpfulLibrariesPath>$(MSBuildThisFileDirectory)Libraries\Lombiq.HelpfulLibraries\Lombiq.HelpfulLibraries.OrchardCore\Lombiq.HelpfulLibraries.OrchardCore.csproj</LombiqHelpfulLibrariesPath> | ||
| </PropertyGroup> |
There was a problem hiding this comment.
Wrong repo, this should be here.
There was a problem hiding this comment.
I think if I put it inside the main project's Directory.Build.props this one overrides it (OCC's build.props without the variable), deleting the value. I tried this and gives me nothing:
When I put it in this Directory.Build.props (OCC's) I can see the path in the console.
There was a problem hiding this comment.
I found this documentation. What a horrible system. Then put the property back into the OrchardCore.Commerce.csproj and let's get this over with.
I learn something bad about MSBuild every day smh...
sarahelsaig
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEST-319
Fixes #129