OCC-17: Inconsistent currency configuration after setup #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahelsaig
requested changes
Aug 2, 2022
src/Modules/OrchardCore.Commerce/Services/ShoppingCartHelpers.cs
Outdated
Show resolved
Hide resolved
0liver
reviewed
Aug 3, 2022
| T["Can't add product {0} because it doesn't have a price.", line.ProductSku]); | ||
| // Localized strings need to be in one line. | ||
| #pragma warning disable S103 // Long line (which is greater than 150 authorized) | ||
| T["Can't add product {0} because it doesn't have a price, or its currency doesn't match with the current display currency.", line.ProductSku]); |
There was a problem hiding this comment.
I know I'm too late for the party, but match sounds better without with:
Suggested change
| T["Can't add product {0} because it doesn't have a price, or its currency doesn't match with the current display currency.", line.ProductSku]); | |
| T["Can't add product {0} because it doesn't have a price, or its currency doesn't match the current display currency.", line.ProductSku]); |
Same in the view.
sarahelsaig
added a commit
that referenced
this pull request
Aug 3, 2022
sarahelsaig
added a commit
that referenced
this pull request
Aug 3, 2022
It's no longer relevant since #140 was merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCC-17
Fixes #105