OCC-32: Add Checkout permission #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DemeSzabolcs
commented
Aug 22, 2022
src/Modules/OrchardCore.Commerce/Drivers/StripeApiSettingsDisplayDriver.cs
Show resolved
Hide resolved
sarahelsaig
requested changes
Aug 22, 2022
| ICardPaymentService cardPaymentService, | ||
| IStringLocalizer<PaymentController> stringLocalizer, | ||
| IAuthorizationService authorizationService, | ||
| IHttpContextAccessor hca) |
There was a problem hiding this comment.
This class is a Controller. It already had this.HttpContext and this.User so you don't need HCA.
| { | ||
| var user = _hca.HttpContext?.User; | ||
|
|
||
| if (user != null && !await _authorizationService.AuthorizeAsync(user, Permissions.Checkout)) |
There was a problem hiding this comment.
HttpContext is never null in an MVC controller, so you don't need to check for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCC-32
Fixes #154