Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product recipe #27

Merged
merged 2 commits into from
Apr 18, 2019
Merged

Product recipe #27

merged 2 commits into from
Apr 18, 2019

Conversation

agriffard
Copy link
Member

I tested with an OC instance setup from a Saas recipe which has only a few modules enabled.

The feature needs a dependency on OrchardCore.Contents in the Manifest or else, enabling it will produce an error.

Then, I defined a Product content type with those parts:
Title
Autoroute
Html
Product
Price

and created 2 products.

Finally, I exported it as a recipe and made it available with a Product.recipe.json file that will enable the required features and create the content type and the sample data.

Copy link
Member

@bleroy bleroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks, but do we really want the two sample products in the recipe?

@agriffard
Copy link
Member Author

Ok, samples removed.

I was also wondering whether adding a 'Product Image' Media picker.
In that case, a Product detail and summary templates (or specific to the ProductImage) could be interesting.

@bleroy
Copy link
Member

bleroy commented Apr 18, 2019

Maybe, it seems pretty unlikely that you would not want an image, and for those cases, it's easy to remove. Eventually, I'd also like to have a separate sample recipe that sets up a complete sample site, with a catalog, etc. That one is different: it's not a starting point, it's a sample. For your recipe, we should focus on most common requirements. Cheers!

@bleroy bleroy merged commit 8d6bc6b into master Apr 18, 2019
@bleroy bleroy deleted the productRecipe branch April 18, 2019 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants