OCC-169: Add user editor for the non-address checkout fields too #314
Conversation
src/Modules/OrchardCore.Commerce/Extensions/UserManagerExtensions.cs
Outdated
Show resolved
Hide resolved
| else | ||
| { | ||
| var errors = _updateModelAccessor.ModelUpdater.GetModelErrorMessages(); | ||
| foreach (var error in errors.WhereNot(string.IsNullOrEmpty)) await _notifier.ErrorAsync(H[error]); |
There was a problem hiding this comment.
I'm pretty sure the validation errors are already localized so this should rather be H["{0}", error].
| /// if the corresponding <see cref="User"/> is not <see langword="null"/>, returns <see langword="null"/> otherwise. | ||
| /// </summary> | ||
| public static async Task<UserDetailsPart> GetUserDetailsAsync(this UserManager<IUser> userManager, ClaimsPrincipal principal) => | ||
| await userManager.GetUserAsync(principal) is User user ? user.As<ContentItem>(UserDetails)?.As<UserDetailsPart>() : null; |
There was a problem hiding this comment.
If you write (await userManager.GetUserAsync(principal) as User)? instead of user then the conditional expression can be avoided.
There was a problem hiding this comment.
(await userManager.GetUserAsync(principal) as User)?.As<ContentItem>(UserDetails)?.As<UserDetailsPart>(); can here indeed be a shortcut as you don't need the instance of the User type in this class.
There was a problem hiding this comment.
Same applies for the method above this one.
|
|
||
| const string getInputsScript = @"return JSON.stringify( | ||
| Array.from(document.querySelectorAll('form[action=\'/user/details\'] input, form[action=\'/user/details\'] select')) |
There was a problem hiding this comment.
You can also use backticks as string delimiter in JS (even if it's not a template string), so you won't run out of quote types:
| Array.from(document.querySelectorAll('form[action=\'/user/details\'] input, form[action=\'/user/details\'] select')) | |
| Array.from(document.querySelectorAll(`form[action='/user/details'] input, form[action='/user/details'] select`)) |
OCC-169
Fixes #313