OCC-67: Add OrderPart permissions #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Psichorex
requested changes
Jul 25, 2023
| // Regular users should only see their own Orders, while users with the ManageOrders permission should be | ||
| // able to see all Orders. | ||
| if (!await _authorizationServiceLazy.Value.AuthorizeAsync(context.User, Permissions.ManageOrders) && | ||
| context.User.Identity.Name != order.ContentItem.Author) |
There was a problem hiding this comment.
Identitiy? should be used here as it is a nullable type and can lead to an exception.
| context.Fail(); | ||
| } | ||
|
|
||
| return; |
There was a problem hiding this comment.
This return here is redundant.
Psichorex
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCC-67
Fixes #115