OCC-183: Check 'Maximum Order Quantity' update on Cart #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porgabi
commented
Sep 19, 2023
test/OrchardCore.Commerce.Tests.UI/Tests/OrderTests/OrderSuccessTests.cs
Show resolved
Hide resolved
|
I assume the PR was left as draft by mistake. |
sarahelsaig
requested changes
Sep 21, 2023
src/Modules/OrchardCore.Commerce/Controllers/ShoppingCartController.cs
Outdated
Show resolved
Hide resolved
test/OrchardCore.Commerce.Tests.UI/Tests/InventoryTests/InventoryBehaviourTests.cs
Outdated
Show resolved
Hide resolved
test/OrchardCore.Commerce.Tests.UI/Tests/InventoryTests/InventoryBehaviourTests.cs
Outdated
Show resolved
Hide resolved
sarahelsaig
requested changes
Sep 21, 2023
This comment was marked as resolved.
This comment was marked as resolved.
|
Ah, I suppose you mean setting the |
Yes, for the quantity inputs. |
sarahelsaig
requested changes
Sep 22, 2023
| : 0); | ||
| maxOrderQuantity = (int)(inventoryPart.MaximumOrderQuantity.Value > 0 && !inventoryPart.IgnoreInventory.Value | ||
| ? inventoryPart.MaximumOrderQuantity.Value | ||
| : 1); |
There was a problem hiding this comment.
The default value for max shouldn't be 1. For example if I fill out the minimum but not the maximum
then this sets it to min="2" max="1" which is invalid.
It's probably fine to use int.MaxValue instead of 1.
sarahelsaig
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCC-183
Fixes #340