Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCC-199: Prevent checking out if there are unavailable products in the cart #377

Merged
merged 18 commits into from
Nov 20, 2023
Merged

OCC-199: Prevent checking out if there are unavailable products in the cart #377

merged 18 commits into from
Nov 20, 2023

Conversation

porgabi
Copy link
Contributor

@porgabi porgabi commented Nov 11, 2023 •
edited by github-actions bot

OCC-199
Fixes #375

@porgabi
Hiding checkout button if any of the items in cart cannot be bought
e964b26
@porgabi
Preventing access to checkout page if there's an invalid item in cart
8c9d101
@porgabi
Moving logic to controller
4238b05
@porgabi
Merge remote-tracking branch 'origin/main' into issue/OCC-199
103014d 
# Conflicts:
#	src/Modules/OrchardCore.Commerce/Services/PaymentService.cs
#	src/Modules/OrchardCore.Commerce/Services/ShoppingCartHelpers.cs
#	src/Modules/OrchardCore.Commerce/ViewModels/CheckoutViewModel.cs
#	src/Modules/OrchardCore.Commerce/Views/ShoppingCart/Index.cshtml
@porgabi
Working on fixing everything
5f58675
@porgabi
Adding event; simplifying logic
19b024a
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@porgabi porgabi marked this pull request as ready for review November 13, 2023 15:44
@sarahelsaig
Copy link
Contributor

I found a way to still reproduce the original error. If you set the inventory of Test Free Product (which allows back-order) to 0 and try to check out you still get the "Inventory value cannot be negative." error.

sarahelsaig
sarahelsaig requested changes Nov 14, 2023
View reviewed changes
src/Libraries/OrchardCore.Commerce.Abstractions/Abstractions/ICheckoutEvents.cs Outdated Show resolved Hide resolved
src/Modules/OrchardCore.Commerce.Payment/Services/PaymentService.cs Outdated Show resolved Hide resolved
src/Modules/OrchardCore.Commerce.Payment/Services/PaymentService.cs Outdated Show resolved Hide resolved
src/Modules/OrchardCore.Commerce/Services/ShoppingCartHelpers.cs Outdated Show resolved Hide resolved
src/Modules/OrchardCore.Commerce/Views/ShoppingCart/Index.cshtml Outdated Show resolved Hide resolved
test/OrchardCore.Commerce.Tests.UI/Tests/InventoryTests/InventoryBehaviourTests.cs Outdated Show resolved Hide resolved
src/Modules/OrchardCore.Commerce/Views/ShoppingCart/Index.cshtml Outdated Show resolved Hide resolved
test/OrchardCore.Commerce.Tests.UI/Tests/InventoryTests/InventoryBehaviourTests.cs Outdated Show resolved Hide resolved
test/OrchardCore.Commerce.Tests.UI/Tests/InventoryTests/InventoryBehaviourTests.cs Outdated Show resolved Hide resolved
@porgabi
Copy link
Contributor Author

porgabi commented Nov 15, 2023

I found a way to still reproduce the original error. If you set the inventory of Test Free Product (which allows back-order) to 0 and try to check out you still get the "Inventory value cannot be negative." error.

Looks like the allows back order value is not properly taken into account during checkout. How should this work when the inventory still has items available and back ordering is allowed -- inventory should be decreased as normal, right? As long as it doesn't go below 0, that is.

@sarahelsaig
Copy link
Contributor

I found a way to still reproduce the original error. If you set the inventory of Test Free Product (which allows back-order) to 0 and try to check out you still get the "Inventory value cannot be negative." error.

Looks like the allows back order value is not properly taken into account during checkout. How should this work when the inventory still has items available and back ordering is allowed -- inventory should be decreased as normal, right? As long as it doesn't go below 0, that is.

Yeah, inventory should still be decreased. I think you just have to change this line to also take inventoryPart.AllowsBackOrder into consideration

sarahelsaig
sarahelsaig requested changes Nov 16, 2023
View reviewed changes
src/Modules/OrchardCore.Commerce/Services/LocalInventoryProvider.cs Outdated Show resolved Hide resolved
src/Modules/OrchardCore.Commerce/Services/ProductInventoryService.cs Outdated Show resolved Hide resolved
src/Modules/OrchardCore.Commerce/Abstractions/IProductInventoryService.cs Show resolved Hide resolved
src/Modules/OrchardCore.Commerce/Events/InventoryShoppingCartEvents.cs Outdated Show resolved Hide resolved
src/Modules/OrchardCore.Commerce/Events/InventoryShoppingCartEvents.cs Outdated Show resolved Hide resolved
src/Modules/OrchardCore.Commerce/Events/InventoryCheckoutEvents.cs Outdated Show resolved Hide resolved
src/Modules/OrchardCore.Commerce/Events/InventoryCheckoutEvents.cs Outdated Show resolved Hide resolved
@sarahelsaig sarahelsaig merged commit c47329e into main Nov 20, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahelsaig sarahelsaig sarahelsaig requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent checking out if there are unavailable products in the cart (OCC-199)
2 participants
@porgabi @sarahelsaig