Currency serialization fixes #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bleroy
requested changes
Feb 5, 2020
Fix reading known currencies and add back initialization of default currency configured in settings.
microposmp
force-pushed
the
currency-fixes
branch
from
51c04de
to
78c7884
Compare
bleroy
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix reading known currencies and add back initialization of default currency configured in settings.
I've only done tests with the PricePart, The changes are not verified with the PriceVariantsPart.
The main issue was that when a known currency was saved only the CurrencyIsoCode is saved. When reading it back the missing values resulted in it being handled as unknown.
Added back the CommerceSettingsConfiguration so that the default currency configured for the site is taken into consideration.