Not the checkout process #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces an address library with an address data type, address formatters, and some region data. Introduces an order part and an address part.
… used before. Also, make more stuff immutable. And fix tests broken by previous stuff. And catch up to the latest Orchard build's breaking changes.
…tion folder. Changed Orchard Core references from project references to NuGet package references. Added a package reference to OrchardCore.Module.Targets.
Removed the OrchardCore clone dependency from the "Setting up your dev environment" instructions in the readme
Removed the OrchardCore clone dependency to make this repo stand alone
|
Everything I have looked through seems really good. Is there any reason not to merge this? It seems like a stabilizing commit that will serve as a launching point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... but some important changes, catch-up with latest Orchard, introducing a shopping cart class, first workflow activity, modeling international addresses, orders, and more. Will merge this sooner rather than later, then continue work towards full checkout process.