Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Culture Selector Display on front #15774

Closed
agriffard opened this issue Apr 16, 2024 · 6 comments · Fixed by #15776
Closed

Culture Selector Display on front #15774

agriffard opened this issue Apr 16, 2024 · 6 comments · Fixed by #15776
Assignees
Labels
Milestone

Comments

@agriffard
Copy link
Member

When the Content culture selector feature is enabled with French and English cultures, the currently selected culture is not displayed correctly:

image

image

image

@Piedone
Copy link
Member

Piedone commented Apr 16, 2024

What would be the correct display?

@agriffard
Copy link
Member Author

agriffard commented Apr 16, 2024

What would be the correct display?

In admin, the currently selected culture shows the friendly name of the culture, not the culture code :

image

That is what I expect to see.

@Piedone
Copy link
Member

Piedone commented Apr 16, 2024

I see. It seems we just need to use @currentCulture.Name instead of @currentCulture here. Looks like something a new contributor could take on.

This isn't a regression, right?

@Piedone Piedone added this to the 1.x milestone Apr 16, 2024
@hishamco
Copy link
Member

I think it's a regression, I remember everything was working fine

@hishamco hishamco self-assigned this Apr 16, 2024
@Piedone
Copy link
Member

Piedone commented Apr 16, 2024

Indeed it is: 980f322#diff-646554b6305f761642dc52e09e1cf0660af19bc6f28727f41723b21f147f129c. So we should fix this for 1.9.

@Piedone Piedone modified the milestones: 1.x, 1.9 Apr 16, 2024
@hishamco
Copy link
Member

I fix it, a PR will be there soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants