Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Profile configs are not respected #15975

Closed
sarahelsaig opened this issue May 4, 2024 · 1 comment · Fixed by #15976
Closed

Feature Profile configs are not respected #15975

sarahelsaig opened this issue May 4, 2024 · 1 comment · Fixed by #15976
Labels
Milestone

Comments

@sarahelsaig
Copy link
Contributor

Describe the bug

Somewhat a followup from #15451. You are able to create a feature profile, but it doesn't take effect.

To Reproduce

Steps to reproduce the behavior:

  1. Set up a new site using the latest preview packages.
  2. Enable Tenants and Tenant Feature Profiles features.
  3. Go to Admin > Multi-Tenancy > Feature Profiles.
  4. Click "Add Feature Profile" button.
  5. Give it any name and copy the example rules from the text under the Rules field. ([{"Rule":"Exclude","Expression":"OrchardCore.Flows"}])
  6. Click "Save and Continue".
  7. Go to Admin > Multi-Tenancy > Tenants
  8. Click "Add Tenant" button
  9. Set any name and URL prefix, select the "Software as a Service" recipe (for convenience), Sqlite database and the feature profile we've just created.
  10. Click the "Create" and then the "Setup" buttons.
  11. Set up the site.
  12. Log in and go to Admin > Configuration > Features.
  13. Observe that "Flows (OrchardCore.Flows)" is still on the list.
  14. Enable Flows.
  15. Observe that it was successfully enabled even though it's excluded by the feature profile.

Additional note: The same happens when the feature profile is imported from a recipe such as this one.

Expected behavior

The feature with the "Exclude" rule should not show up in the tenant's feature list.

@agriffard agriffard changed the title Feature Profule configs are not respected Feature Profile configs are not respected May 4, 2024
@TonyWoo
Copy link
Contributor

TonyWoo commented May 5, 2024

Based on my testing(main branch), it turns out the profile rule didn't get saved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants