Should [shortcode] be resolved to an actual value when converting HtmlBodyPart or MarkdownBodyPart is graphql?

[MikeAlhayek]

When we have shortcodes like [site_name], [image]file1.jpg[/image] or any other shortcode in HtmlBodyPart or MarkdownBodyPart, shouldn't we process the shortcodes and return the raw value?

When we return content using REST API, returning the '[shortcode]` is not as useful as returning the resolved values.

Thoughts?

[Piedone]

I don't think we should return this processed content where we return the source currently, but we can have new fields to produce it. Kind of like rendered.

[MikeAlhayek]

I agree with you. render property for these two parts is a good choice to allow us to be able to render both versions of the part.

[MikeAlhayek]

After looking more at the code, it turn out that we already process the HTML and markdown part/field from shortcodes. This is a false alarm.

OrchardCore/src/OrchardCore.Modules/OrchardCore.Html/GraphQL/HtmlBodyQueryObjectType.cs

Line 59 in 39c970e

return await shortcodeService.ProcessAsync(html,

OrchardCore/src/OrchardCore.Modules/OrchardCore.Markdown/GraphQL/MarkdownFieldQueryObjectType.cs

Line 88 in 39c970e

html = await shortcodeService.ProcessAsync(html,

OrchardCore/src/OrchardCore.Modules/OrchardCore.Markdown/GraphQL/MarkdownFieldQueryObjectType.cs

Line 88 in 39c970e

html = await shortcodeService.ProcessAsync(html,