Notification editor doesn't close when saving a draft

[maksim-markin]

Describe the bug

There is an issue with updating content item: when there is a change content item with current culture changing the notification editor doesn't close.

Orchard Core version

1.8.2.

To Reproduce

Steps to reproduce the behavior:

1. Go to Manage Content page
2. Click Add New Global Notification
3. Set some Html text and Content localization to English
4. Еhere is a parameter "returnUrl" in the address bar
5. Press Publish button
6. On Manage Content page select published notification for editing
7. Change Current culture to other language (in this step we are losing a parameter "returnUrl") and change Html text
8. Press Publish button again

Expected behavior

The editor window should close and return to Manage Content page.

Logs and screenshots

[github-actions]

Thank you for submitting your first issue, awesome! 🚀 We're thrilled to receive your input. If you haven't completed the template yet, please take a moment to do so. This ensures that we fully understand your feature request or bug report. A core team member will review your issue and get back to you.

If you like Orchard Core, please star our repo and join our community channels.

[hishamco]

@MikeAlhayek is this by design?

[MikeAlhayek]

I am not sure. I did not design the culture feature

[hishamco]

I thought it was notification-related. I will have a look then

[maksim-markin]

This behavior actual with every content type not for only notification

[hishamco]

Please another screenshot

[maksim-markin]

1. Open Manage Content (type = page)
   

2. Edit some page (there is a returnUrl param) and change current localization
   

3. Localized version has been created (there is no returnUrl param)
   

4. After published, page doesn`t close
   

[sebastienros]

@maksim-markin We understand that you created a type name "Global Notification" and this is not related to the notifications module (that was confusing so I prefer the state it).

My understanding of the issue is that the return url is lost when we switch languages, so publishing a new localized version won't go back to the content items page like when create a new content item does.

[github-actions]

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

[sebastienros]

I kind of agree with the expectation, that we should return to the previous returnUrl value if there was one.

[maksim-markin]

@maksim-markin We understand that you created a type name "Global Notification" and this is not related to the notifications module (that was confusing so I prefer the state it).

My understanding of the issue is that the return url is lost when we switch languages, so publishing a new localized version won't go back to the content items page like when create a new content item does.

This behavior actual with every content type not for only notification
See screens above

[maksim-markin]

Related Pull Request: #16325

[hishamco]

I unassigned myself while you started a PR