Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Media files for a removed tenant when using AWS S3 #16404

Open
Piedone opened this issue Jul 5, 2024 · 1 comment
Open

Remove Media files for a removed tenant when using AWS S3 #16404

Piedone opened this issue Jul 5, 2024 · 1 comment

Comments

@Piedone
Copy link
Member

Piedone commented Jul 5, 2024

Is your feature request related to a problem? Please describe.

If you remove a tenant, its Media files are only removed if they use the default local storage in App_Data. When using AWS S3 though, they remain.

Similar to #16403.

Describe the solution you'd like

Add an IShellRemovingHandler to OrchardCore.Media.AmazonS3 that removes Media files from S3 too. This should support both removing the whole bucket if tenants' Media are stored in separate buckets, or just the "folder" if a single container is used.

Describe alternatives you've considered

You can also have a custom IShellRemovingHandler implementation for this, but I think this should be a core functionality.

Copy link

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants