Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Average Hit Points calculating incorrectly #462

Closed
DivertedCircle opened this issue Oct 11, 2020 · 1 comment · Fixed by #464
Closed

Average Hit Points calculating incorrectly #462

DivertedCircle opened this issue Oct 11, 2020 · 1 comment · Fixed by #464
Assignees
@datdamnzotz
Labels
area/application Task related to orcpub application itself bug Something isn't working
Projects
Orcpub
Milestone
2.5.0.17

Comments

@DivertedCircle
Copy link

DivertedCircle commented Oct 11, 2020 •
edited
Loading

Describe the bug
Average hit points for a character are supposed to take the average of a class' hit die, then round up. The rounding up is not occurring on the Patron windows server.

To Reproduce

Steps to reproduce the behavior:

  1. Create a new character.
  2. Add various class levels.
  3. Hit the 'Average' button to calculate hit points.
  4. See that the average being entered does not match the PHB entries for a class, or the live site.

Expected behavior

For a Fighter the average should be 6 but it's being entered as a 5. Wizards should get a 4 but it's entering 3.

Screenshots

If applicable, add screenshots to help explain your problem.

Live site:
image

Patron server:
image
@DivertedCircle DivertedCircle added area/application Task related to orcpub application itself bug Something isn't working labels Oct 11, 2020
@DivertedCircle
Copy link
Author

As noted on the Discord server, this appears to have been caused by #460.

datdamnzotz added a commit to datdamnzotz/orcpub that referenced this issue Oct 12, 2020
@datdamnzotz
Fixes Orcpub#462
5023f61 
Made functions clearer what they do
@datdamnzotz datdamnzotz mentioned this issue Oct 12, 2020
Merged
5 tasks
@datdamnzotz datdamnzotz changed the title Average Hit Points calculating incorrectly on Patron Server Average Hit Points calculating incorrectly Oct 12, 2020
@datdamnzotz datdamnzotz added this to To do in Orcpub via automation Oct 12, 2020
@datdamnzotz datdamnzotz self-assigned this Oct 12, 2020
@datdamnzotz datdamnzotz added this to the 2.5.0.17 milestone Oct 12, 2020
Orcpub automation moved this from To do to Done Oct 14, 2020
datdamnzotz added a commit that referenced this issue Oct 14, 2020
@datdamnzotz
Merge pull request #464 from datdamnzotz/#460-fix-for-monster-hp
12d581c 
Fixes Average Hit Points calculating incorrectly #462
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@datdamnzotz datdamnzotz

Labels
area/application Task related to orcpub application itself bug Something isn't working
Projects
Orcpub
  
Done
Milestone
2.5.0.17
Development

Successfully merging a pull request may close this issue.

Fixes Average Hit Points calculating incorrectly #462 datdamnzotz/orcpub
2 participants
@datdamnzotz @DivertedCircle