Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-compliance to Style Guide #28

Closed
sab56 opened this issue Jun 21, 2021 · 6 comments
Closed

Non-compliance to Style Guide #28

sab56 opened this issue Jun 21, 2021 · 6 comments

Comments

@sab56
Copy link

sab56 commented Jun 21, 2021

The styles defined in these stylesheets do not conform to the styles in the style guide published by the OS. The differences between the ArcMap layer file styles and the styles defined in the style guide are shown in the attached PDF document.
osmm_topo_arcmap_styling_issues.pdf

@egil1978
Copy link
Contributor

Hi @sab56
Thank for getting in touch. It looks like the style guide might need updating in places. Let me take a closer look and ill get back to you shortly. :)

@egil1978
Copy link
Contributor

Hi @sab56, would you be ok pointing us to the style guide you are refering to with the images in your PDF? The style guide we are looking at does not appear to have the same pattern images that you have screenshot. Many thanks.

@sab56
Copy link
Author

sab56 commented Sep 15, 2021

Hi @egil1978, the pattern images in my PDF were not cut and pasted from the style guide, I constructed them in ArcMap from the SVG definitions in the style guide.

@egil1978
Copy link
Contributor

Hi sab56, thanks for getting back to us. There does seem to be some discrepancies between how the style guide describes the SVG's and the SVG's we use as part of our stylesheets. The style guide is about 20 years old now and was put together when OSMM Topo was first released in 2001. Since then the styles have evolved somewhat and sadly it seems the style guide has not been updated to reflect this. We are constantly improving all of our stylesheets and will take the issues you have raised into consideration when we next update them.

@sab56
Copy link
Author

sab56 commented Oct 5, 2021

The stylesheets appear to be an extremely poor implementation of the style guide. The ArcMap layer files are particularly bad, containing numerous errors, e.g. non coniferous tree symbol used for both coniferous and non coniferous trees.

@egil1978
Copy link
Contributor

egil1978 commented Oct 6, 2021

Hi @sab56, we are looking at the stylesheets now and will amend the doc accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants