Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.12] Client crash - late SoundEvent registration #126

Closed
ghost opened this issue Jul 6, 2017 · 12 comments
Closed

[1.12] Client crash - late SoundEvent registration #126

ghost opened this issue Jul 6, 2017 · 12 comments
Assignees
@OreCruncher
Labels
bug Yep, it's a problem. fixed in dev Fixed and committed to source control; not in a published build
Milestone
v3.4.6.0

Comments

@ghost
Copy link

ghost commented Jul 6, 2017

Mod Version: DynamicSurroundings-1.12-3.4.5.7

Forge Version: 2397

Link to crash log (if applicable):
crash-2017-07-06_17.44.48-client.txt

Description:
i was in server, and it crashed instantly. (not server, client)
and i didn't install DS to the server side, did i make correct? sorry if im not
@ghost
Copy link
Author

ghost commented Jul 6, 2017

hey ah, it happens if i jump.

@ghost
Copy link
Author

ghost commented Jul 6, 2017 •
edited by ghost

and no, not about the server side. it crashes everytime i jump in a server. :/

@OreCruncher
Copy link
Owner

OK. I have to do more code rearranging. Despite what the Forge guys say it is never an easy migration to a newer version. They keep changing things around. :\

@ghost
Copy link
Author

ghost commented Jul 6, 2017

okay no worry we are waiting :)

@OreCruncher
Copy link
Owner

What's funny is that I don't experience the problem on my system.

@ghost
Copy link
Author

ghost commented Jul 6, 2017

really?

@OreCruncher
Copy link
Owner

Yep. Try out this JAR and let me know if it fixes: https://github.com/OreCruncher/DynamicSurroundings/releases/tag/v3.4.6.0T1

@ghost
Copy link
Author

ghost commented Jul 6, 2017

i will. give me a little bit time

@ghost
Copy link
Author

ghost commented Jul 6, 2017

and ah, should i install DS on server side? need answer for this

@ghost
Copy link
Author

ghost commented Jul 6, 2017

ahhh yes, that version works with no crash. thank you.

@ghost ghost closed this as completed Jul 6, 2017
@OreCruncher OreCruncher reopened this Jul 6, 2017
@OreCruncher
Copy link
Owner

Gonna leave open until I post an official build.

@OreCruncher OreCruncher self-assigned this Jul 6, 2017
@OreCruncher OreCruncher added the bug Yep, it's a problem. label Jul 6, 2017
@OreCruncher OreCruncher added this to the v3.4.6.0 milestone Jul 6, 2017
@OreCruncher OreCruncher changed the title Crashed In Server [1.12] Client crash - late SoundEvent registration Jul 6, 2017
OreCruncher added a commit that referenced this issue Jul 6, 2017
@OreCruncher
[#126] Fix late sound registration crash; more mod support
6da23a0
OreCruncher added a commit that referenced this issue Jul 6, 2017
@OreCruncher
[#126] Fix late sound registration crash; more mod support
200dc74
OreCruncher added a commit that referenced this issue Jul 6, 2017
@OreCruncher
[#126] Fix late sound registration crash; more mod support
470a4e1
@OreCruncher OreCruncher added the fixed in dev Fixed and committed to source control; not in a published build label Jul 6, 2017
This was referenced Jul 7, 2017
Closed
Closed
@OreCruncher OreCruncher modified the milestones: v3.4.5.8, v3.4.6.0 Jul 15, 2017
@OreCruncher
Copy link
Owner

Fix pushed to CurseForge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OreCruncher OreCruncher

Labels
bug Yep, it's a problem. fixed in dev Fixed and committed to source control; not in a published build
Projects
None yet
Milestone
v3.4.6.0
Development

No branches or pull requests
1 participant
@OreCruncher