Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ingest collections #158

Merged
merged 3 commits into from
Jun 19, 2015
Merged

Feature/ingest collections #158

merged 3 commits into from
Jun 19, 2015

Conversation

luisgreg99
Copy link
Contributor

fixes #137

hydra_editor:
form:
model_label:
GenericSet: "Collection"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to change the label. Collection has meaning in libraries that we don't want to confuse.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wickr You seemed to have the most opinions on this before - should the form for ingest say "Set" or "Collection"?

@wickr
Copy link
Member

wickr commented Jun 18, 2015

@terrellt @luisgreg99 I think it should say Set.

There's been a lot of confusion over the interchangeableness for Set/Collection, plus having Local Collection Name. I would strongly prefer to use Set where it's Set, in both front and backend UI, and keep Collection part of Local Collection Name/ID.

This could be another discussion topic for the meeting on the 29th. Similar to the object/item/record/asset discussion. We can settle on our vocabulary.

tpendragon pushed a commit that referenced this pull request Jun 19, 2015
@tpendragon tpendragon merged commit 5191f20 into master Jun 19, 2015
@tpendragon tpendragon deleted the feature/IngestCollections branch June 19, 2015 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ingest collections.
3 participants