Required Template Fields #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| </div> | ||
| </div> | ||
| <div class="panel-body"> | ||
| <%= p.input :visible, :label => "Show" %> |
There was a problem hiding this comment.
You're hurting accessibility here by removing the full object name from the label. Consider a styled fieldset if you really want to convert to shorter labels.
There was a problem hiding this comment.
There might also be aria attributes you can put on the panel header, but I'm not sure if those exist or are as effective as a fieldset with legend
There was a problem hiding this comment.
You're the best. Will do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to mark template properties as required and then enforce that when ingesting using the template.
Closes #202