Update class-methods.rst #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to be consistent with vocabulary. We should call them either ‘instantiation methods’ or ‘factory methods’, but we should stick to 1 name. I am slightly in favor of the later, but I have no strong opinion on it. (resolved)
I don’t think this bit is needed. It is up to the user which settings they want to use, and using a lot or 1 should make no difference.
On the other hand, in this definition I miss the fact that this class method will not be called at all if from_crawler is also defined, which I believe it a rather important detail. (resolved)