Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextField] Error Handling Implementation #76

Merged
merged 5 commits into from
Sep 15, 2020

Conversation

burbuli8ra
Copy link
Contributor

This PR includes the Error Handling enhancements of TextField component.

Abstract Designs

Closes issue #73

Updates and Changes

  • Addition of error/success indicators
  • Addition of error message
  • Update of label color on error state
  • Update of error handling story

@burbuli8ra burbuli8ra added the enhancement New feature or request label Sep 14, 2020
@burbuli8ra burbuli8ra requested a review from a team September 14, 2020 17:34
@burbuli8ra burbuli8ra added this to Doing in first stable release via automation Sep 14, 2020
@burbuli8ra burbuli8ra self-assigned this Sep 14, 2020
@burbuli8ra burbuli8ra linked an issue Sep 14, 2020 that may be closed by this pull request
3 tasks
Copy link
Contributor

@michalisKout michalisKout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some outdated snapshots. Just run "yarn run test:update" and push the new snapshots to origin 😄 .

@burbuli8ra burbuli8ra force-pushed the feature/textInput-error-handling branch from 525ff94 to f526b90 Compare September 15, 2020 09:02
* Remove unnecessary Boolean from TextFieldProps in TextFieldShowcase
* Update snapshots
@burbuli8ra burbuli8ra force-pushed the feature/textInput-error-handling branch from f526b90 to 34edfd6 Compare September 15, 2020 09:04
@burbuli8ra burbuli8ra merged commit 05d0bbe into staging Sep 15, 2020
first stable release automation moved this from Doing to Done Sep 15, 2020
@burbuli8ra burbuli8ra deleted the feature/textInput-error-handling branch September 15, 2020 11:02
@github-actions
Copy link

🎉 This PR is included in version 0.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

TextField Error Handling
2 participants