Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose ScoreCardTable for usage in custom pages #127

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Expose ScoreCardTable for usage in custom pages #127

merged 2 commits into from
Dec 6, 2022

Conversation

T0RAT0RA
Copy link
Contributor

@T0RAT0RA T0RAT0RA commented Dec 6, 2022 •
edited
Loading

Exposing ScoreCardTable so it can be use in custom pages, without ScoreBoardPage.

✔️ Checklist

  • Added tests for new functionality and regression tests for bug fixes
  • Added changeset (run yarn changeset in the root)
  • Screenshots of before and after attached (for UI changes)
  • Added or updated documentation (if applicable)

@jvilimek jvilimek merged commit 3a2f7b5 into Oriflame:main Dec 6, 2022
@jvilimek
Copy link
Collaborator

jvilimek commented Dec 6, 2022

Thanks as always :)

@jvilimek
Copy link
Collaborator

jvilimek commented Dec 6, 2022

released in v0.5.6

@T0RAT0RA T0RAT0RA deleted the expose-ScoreCardTable branch December 6, 2022 19:26
@T0RAT0RA T0RAT0RA mentioned this pull request Dec 6, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvilimek jvilimek jvilimek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@T0RAT0RA @jvilimek