Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependency added in #132 #144

Closed
wants to merge 2 commits into from

Conversation

T0RAT0RA
Copy link
Contributor

Sorry I forgot to add react-router-dom in #132

✔️ Checklist

  • Added tests for new functionality and regression tests for bug fixes
  • Added changeset (run yarn changeset in the root)
  • Screenshots of before and after attached (for UI changes)
  • Added or updated documentation (if applicable)

@jvilimek
Copy link
Collaborator

No worries. The lint step should have failed in the previous PR during CI phase.. but maybe the sources were not synchronized, this is something I have added just recently (#126)

@T0RAT0RA
Copy link
Contributor Author

It's still failing but I don't know why. I tried a bunch of different updates on the yarn.lock and package.json files, but I don't know what's going on.

@jvilimek
Copy link
Collaborator

jvilimek commented Dec 14, 2022

I believe the "react-router-dom": "6.4.3" needs to be added to devDependencies to the plugin as it is now used in tests

UPDATE:

you may check by running locally yarn backstage-cli repo lint:
image

This will fix it:
image

@jvilimek
Copy link
Collaborator

jvilimek commented Dec 14, 2022

I have updated my comment above. Shall I fix it? I can have PR up and running in no time. It shall be one-liner in one file.

@T0RAT0RA
Copy link
Contributor Author

Shall I fix it?

Yes please, thanks!
there is something wrong with my setup, the linter doesn't pick up the issue. I'l have to investigate later.

@jvilimek
Copy link
Collaborator

sure, np. Created #145 . Closing this one.

@jvilimek jvilimek closed this Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants