Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add config properties to customize reviewer and review date display behavior #250

Merged
merged 7 commits into from
Apr 12, 2024

Conversation

sbstnc
Copy link
Contributor

@sbstnc sbstnc commented Feb 22, 2024

This PR introduces a new config section to customize select aspects of display behavior. Namely, you can elect to display or hide the reviewer and review date information. The default is to always display the information and therefore the implementation is fully backwards compatible. Apart from the static display options 'always' and 'never' we also introduce the variant 'if-data-present' which will show or hide the respective columns dynamically based on the presence or absence of data.

📷 Screenshots

Score Board
Options After
reviewer ✅
review date ✅
(Default, matches before)
reviewer ❌
review date ❌
reviewer ✅
review date ❌
reviewer ❌
review date ✅
Score Card
Options After
reviewer ✅
review date ✅
(Default, matches before)
reviewer ❌
review date ❌
reviewer ✅
review date ❌
reviewer ❌
review date ✅

✔️ Checklist

  • Added tests for new functionality and regression tests for bug fixes
  • Added changeset (run yarn changeset in the root)
  • Screenshots of before and after attached (for UI changes)
  • Added or updated documentation (if applicable)

Copy link
Collaborator

@jvilimek jvilimek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, missed the notification. Thanks a lot for your contribution, nice and elegant solution!

@jvilimek jvilimek merged commit 500e616 into Oriflame:main Apr 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants