Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade veOGV contract with proper name #164

Closed
micahalcorn opened this issue Jul 7, 2022 · 4 comments
Closed

Upgrade veOGV contract with proper name #164

micahalcorn opened this issue Jul 7, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request P1 Large amount of significant user impact, a meaningful feature is broken planned In-scope at the beginning of the sprint
Milestone

Comments

@micahalcorn
Copy link
Member

micahalcorn commented Jul 7, 2022

The new veOGV contract is named veOGV (same as the symbol). We should update the name to be Vote Escrowed Origin Dollar Governance and then ask Etherscan to update their cached version.

@micahalcorn micahalcorn added enhancement New feature or request P1 Large amount of significant user impact, a meaningful feature is broken labels Jul 7, 2022
@franckc
Copy link
Contributor

franckc commented Jul 7, 2022

Here is the function we'll need to fix as part of the upgrade:

@micahalcorn micahalcorn added this to the Sprint 32 milestone Jul 23, 2022
@franckc franckc modified the milestones: Sprint 32, Sprint 31 Jul 25, 2022
@franckc
Copy link
Contributor

franckc commented Aug 5, 2022

The contract code was updated in #298
Left to do:

  • Mainnet deploy
  • Multi-sig transaction to upgrade the proxy's implementation to point to the newly deployed contract

@franckc
Copy link
Contributor

franckc commented Aug 15, 2022

@shahthepro Could you do the deploy of the contract to Mainnet? Let Justin or myself know if you need ETH for that. Also let's verify the contract on etherscan.

Then for submitting the multi-sig transaction to upgrade the proxy's implementation to that new contract, ask for help from either @DanielVF or myself.

@micahalcorn micahalcorn modified the milestones: Sprint 32, Sprint 33 Aug 22, 2022
@micahalcorn micahalcorn modified the milestones: Sprint 33, Sprint 34 Sep 6, 2022
@micahalcorn
Copy link
Member Author

Copying from @shahthepro on Discord:

https://etherscan.io/tx/0x07f84fbed29c91078a100971de693535fc56c4a3f3a9be1aeec0c4662d1b0379 for contract deployment

This is the command I used to run it:

brownie run deploy_staking main 0x9c354503c38481a7a7a51629142963f98ecc12d0 1657584000 0x7d82e86cf1496f9485a8ea04012afeb3c7489397 --network mainnet

The tokenAddress, epoch and rewardsAddress are from the existing contract's values.

The deployed contract is here: https://etherscan.io/address/0x2a4cfbb8168d26f8a3b919a14dbc0cd24b4bc329

Had to add accounts.default = accounts.load("default") line of code when running the deploy_staking script standalone, Didn't commit/push that change though

@franckc franckc modified the milestones: Sprint 34, Sprint 36 Sep 14, 2022
@micahalcorn micahalcorn modified the milestones: Sprint 36, Sprint 35 Sep 15, 2022
@micahalcorn micahalcorn modified the milestones: Sprint 36, Sprint 37 Oct 11, 2022
@micahalcorn micahalcorn added the planned In-scope at the beginning of the sprint label Oct 25, 2022
@micahalcorn micahalcorn removed this from the Sprint 37 milestone Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1 Large amount of significant user impact, a meaningful feature is broken planned In-scope at the beginning of the sprint
Projects
Status: Done
Development

No branches or pull requests

4 participants