fix(OrbitController): limit zoom speed

Orillusion · Jun 27, 2023 · 13608a8 · 13608a8
1 parent 7ad1581
commit 13608a8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Engine3D.ts b/src/Engine3D.ts
@@ -17,7 +17,6 @@ import { ShaderLib } from './assets/shader/ShaderLib';
 import { ShaderUtil } from './gfx/graphics/webGpu/shader/util/ShaderUtil';
 import { ComponentCollect } from './gfx/renderJob/collect/ComponentCollect';
 import { ShadowLightsCollect } from './gfx/renderJob/collect/ShadowLightsCollect';
-import { ProfilerUtil } from '.';
 
 /** 
  * Orillusion 3D Engine
@@ -289,7 +288,7 @@ export class Engine3D {
      * @returns
      */
     public static async init(descriptor: { canvasConfig?: CanvasConfig; beforeRender?: Function; renderLoop?: Function; lateRender?: Function, engineSetting?: EngineSetting } = {}) {
-        console.log('engine version', version);
+        console.log('Engine Version', version);
 
         this.setting = { ...this.setting, ...descriptor.engineSetting }
 

diff --git a/src/components/controller/OrbitController.ts b/src/components/controller/OrbitController.ts
@@ -202,6 +202,7 @@ export class OrbitController extends ComponentBase {
      * @internal
      */
     private onWheel(e: PointerEvent3D) {
+        e.deltaY = clamp(e.deltaY, -this._spherical.radius, this._spherical.radius)
         this._spherical.radius += e.deltaY * this.zoomFactor;
         this._spherical.radius = clamp(this._spherical.radius, this.minDistance, this.maxDistance);
         this.updateCamera();
@@ -231,7 +232,7 @@ export class OrbitController extends ComponentBase {
             this._spherical.phi -= rb * Math.PI / 180;
             this._spherical.phi = clamp(this._spherical.phi, this.minPolarAngle, this.maxPolarAngle);
             this.updateCamera();
-            // pan
+        // pan
         } else if (e.mouseCode === 2) {
             Vector3Ex.mulScale(this.object3D.transform.up, e.movementY * this.panFactor * this._camera.aspect, Vector3.HELP_1);
             this._target.y += Vector3.HELP_1.y;