Skip to content

Commit

Permalink
fix(android): reslove webgpu errors (#170)
Browse files Browse the repository at this point in the history
add contributing 
remove unspport feature
use canvas prefered format as outAttachments format
update readme
  • Loading branch information
lslzl3000 committed May 23, 2023
1 parent 9a89d2b commit a867ea7
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 9 deletions.
6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ If applicable, add screenshots to help explain your problem
## Orillusion engine version
State the version you use for developement, e.g. 0.6.1

## Desktop (please complete the following information)
## Platform (please complete the following information)
- OS: [e.g. win, mac, android]
- Browser [e.g. chrome]
- Version [e.g. 113]
- Browser: [e.g. chrome]
- Version: [e.g. 113]

## Code demo link
If applicabla, please provide a sandbox/codepen/code snippet... to demonstrate the bug.
Expand Down
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/bug_report_zh.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ assignees: ''

## 本机系统 (请填写完整):
- OS: [e.g. win, mac, android]
- Browser [e.g. chrome]
- Version [e.g. 113]
- Browser: [e.g. chrome]
- Version: [e.g. 113]

## 代码示例
如果有sandbox/codepen的代码示例链接,请提供
Expand Down
9 changes: 7 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,13 @@ await Engine3D.init({
Please read the [Docs](https://www.orillusion.com/guide/) to Learn More.

## Platform
**Chrome Desktop: 113+**
**Edge Desktop: 113+**
**Windows/Mac/Linux:**
- Chrome 113+
- Edge: 113+

**Android (Behind the `enable-unsafe-webgpu` flag):**
- Chrome Canary 113+
- Edge Canary 113+

## Useful links
- [Official Web Site](https://www.orillusion.com/)
Expand Down
2 changes: 1 addition & 1 deletion src/gfx/graphics/webGpu/Context3D.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ class Context3D {
}
// request device
this.device = await this.adapter.requestDevice({
requiredFeatures: [`texture-compression-bc`],
//requiredFeatures: [`texture-compression-bc`],
requiredLimits: {
minUniformBufferOffsetAlignment: 256,
maxStorageBufferBindingSize: this.adapter.limits.maxStorageBufferBindingSize
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export class WebGPUDescriptorCreator {
// if(!rps.customSize){
rps.outAttachments = [
{
format: GPUTextureFormat.bgra8unorm,
format: webGPUContext.presentationFormat,
},
];
// }
Expand Down

0 comments on commit a867ea7

Please sign in to comment.