Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(culling): Camera frustum culling #198

Merged
merged 4 commits into from
May 31, 2023
Merged

fix(culling): Camera frustum culling #198

merged 4 commits into from
May 31, 2023

Conversation

hellmor
Copy link
Collaborator

@hellmor hellmor commented May 30, 2023

Fix rendering objects being incorrectly culled by the camera

@hellmor
fix(culling): Camera frustum culling
80ca1ef 
Fix rendering objects being incorrectly culled by the camera
@hellmor
chore: rename class
a38c239 
rename class
@hellmor hellmor added the bug Something isn't working label May 30, 2023
@hellmor hellmor added this to the 0.6 milestone May 30, 2023
@hellmor
fix(boundBox): Init box
29ed570 
fix error : init boundbox
@hellmor
fix(boundBox): Init box
7825ca5 
fix error : init boundbox
lslzl3000
lslzl3000 approved these changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@lslzl3000 lslzl3000 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this pr also fixed the point/spot shadow culling bug #200

@lslzl3000 lslzl3000 linked an issue May 30, 2023 that may be closed by this pull request
[BUG]: point/spot shadow culling bug #200
Closed
@X-OldGentleMan X-OldGentleMan merged commit 8cfd1ab into Orillusion:dev May 31, 2023
1 check passed
@hellmor hellmor deleted the fixBoundBox branch June 1, 2023 06:44
This was referenced Jun 6, 2023
Merged
Merged
@lslzl3000 lslzl3000 mentioned this pull request Aug 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lslzl3000 lslzl3000 lslzl3000 approved these changes

@Codeboy-cn Codeboy-cn Codeboy-cn approved these changes

@X-OldGentleMan X-OldGentleMan Awaiting requested review from X-OldGentleMan

Assignees
No one assigned
Labels
bug Something isn't working
Projects
Engine
Status: ✅ Done
Milestone
0.6
Development

Successfully merging this pull request may close these issues.

[BUG]: point/spot shadow culling bug
4 participants
@hellmor @lslzl3000 @Codeboy-cn @X-OldGentleMan