Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cant Enable "Search Bar" #214

Closed
JonathannHaslett opened this issue Jul 4, 2023 · 8 comments
Closed

Cant Enable "Search Bar" #214

JonathannHaslett opened this issue Jul 4, 2023 · 8 comments
Labels
needs investigation issue / topic that needs more investigation in order to decide what action to take. OkPy

Comments

@JonathannHaslett
Copy link

Describe the bug

  1. Existing OkPy file when i try toggle on the search bar it will appear but when i am in the OkPy IDE but when i execute the file from the browsers or quick access the search bar does not appear.

To Reproduce
Steps to reproduce the behavior:

  1. Go to existing OkPy file with sheets, toggle "searchable" to on
  2. Try clicking save, publish, apply when in the node editor.
  3. Try saving the main OkPy files.
  4. See error - Screenshots below.
  5. When OkPy file is run again no search bar appears

Expected behavior
Search Bar should show.

Observed behavior
Appears to have trouble saving?

Screenshots
If applicable, add screenshots to help explain your problem.
image

image

Desktop (please complete the following information):

  • OS: Windows 10 Pro
  • Revit Version : Revit 2023
  • Dynamo Version :
  • Orkestra Version : 1.7.2

In Which context did it happen (please select from the following list) :
Orkestra Desktop app , Orkestra Revit Addin, Orkestra Dynamo View Extension

Additional context
Add any other relevant info about the problem here.

@JonathannHaslett
Copy link
Author

If i create a brand new OkPy file I can enable search, but when I type along the top to filter the list it doesn't work.

image

@MostafaElAyoubi
Copy link
Member

thank you for reporting this @JonathannHaslett ! we're going to look into adding the search bar to existing tools.
I believe the search does work though. On your second screenshot, it looks like it navigated low enough for items containing "bs07" to appear. We could make it so the item gets highlighted to. But it is true that the items won't be brought to top of the list. I just browses lox enough for it to show. I hope this makes sens.

@MostafaElAyoubi MostafaElAyoubi added OkPy needs investigation issue / topic that needs more investigation in order to decide what action to take. labels Jul 4, 2023
@JonathannHaslett
Copy link
Author

Thanks Mostafa, i guess i was expecting the search to filter out data so the only thing you see in the list would only be items/ strings that contains BS07, maybe this is not possible?

@MostafaElAyoubi
Copy link
Member

oh interesting! yes that could be implemented for sure. Let's keep this topic open until it is.

@MostafaElAyoubi
Copy link
Member

MostafaElAyoubi commented Jul 26, 2023

@JonathannHaslett Coming along nicely! 😁
ListviewSearch

@JonathannHaslett
Copy link
Author

@JonathannHaslett Coming along nicely! 😁 ListviewSearch

Look good Mostafa :)

Any idea when this will become available

@MostafaElAyoubi
Copy link
Member

Hey @JonathannHaslett ! Target for next release is october 🤞

@MostafaElAyoubi
Copy link
Member

Implemented in 1.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs investigation issue / topic that needs more investigation in order to decide what action to take. OkPy
Projects
None yet
Development

No branches or pull requests

2 participants