This repository has been archived by the owner on Jul 9, 2023. It is now read-only.
Fix for UpdateIAmAlive in CosmosDBMembershipTable.cs #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… passed in from Orleans only contained SiloAddress and IAmAliveTime. The code now reads the existing state from Cosmos Db, updates IAmAliveTime and writes it back. From what I can see, this is what UpdateIAmAlive.js used to do.
ReubenBond
force-pushed
the
UpdateIAmAliveFix
branch
from
f43b8a4
to
65a40de
Compare
This was referenced Jun 16, 2021
davidvanchu
reviewed
Dec 17, 2021
| } | ||
| else | ||
| { | ||
| grainState.State = Activator.CreateInstance(grainState.State.GetType()); | ||
| grainState.RecordExists = true; |
There was a problem hiding this comment.
@ReubenBond I think this is supposed to be false, per this original PR: https://github.com/OrleansContrib/Orleans.CosmosDB/pull/48/files#diff-f6c48f97559f4c1c65df1b87a7db74cc98308c699c48d0b4a10da1ad0c463272R161
as well as the MockStorageProvider from the tests, which sets it to false if there was no prior state: https://github.com/dotnet/orleans/blob/154feab1d49ee5c8e2590832d40a32e5c9ad4b26/test/TestInfrastructure/TestExtensions/MockStorageProvider.cs#L207
There was a problem hiding this comment.
Ah, you're right. Thanks for catching that, @davidvanchu! Are you able to open a PR to fix it?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #49 and #48, which I do not have the permissions to update.