-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bind IAddressable instances to runtime when deserializing from JSON #10 #11
fix: bind IAddressable instances to runtime when deserializing from JSON #10 #11
Conversation
The format selection in RedisGrainStorage.GetKey ( |
What is wrong with the CI? The test stage takes hours and then gets canceled? |
I'm not sure @heikki-heikkinen-ptcs - does this work locally for you? |
By the way, have you seen dotnet/orleans#6936? |
Yes, test pass locally. They are a bit heavy since they require an actual redis instance to be running. I would strongly recommend checking out the branch while reviewing and running it locally. You tend not to see enough of the context when only looking at the diff. And no, I have not seen that. I'll have to check it out. |
Those CI tests run against a Redis container. |
Tests were timing out in PR build. Removing new PubSub tests to make sure they were not the culprit
@ReubenBond I removed the test class I added and tests seem to pass now. |
Ignore Rider files
Tests were timing out in PR build. Removing new PubSub tests to make sure they were not the culprit
Resolved conflicts with target branch. Is this ever going to get reviewed? |
Many apologies, @heikki-heikkinen-ptcs, I completely missed this. |
Uses Orleans JSON serialization settings instead of copy-pasting the same code to this library. Orleans.Core was already referenced.
Extracts serialization to/from RedisValue behind an interface where the implementation is selected when bootstrapping.
Attempts to fix migration from old implementation where state was stored as a plain key without etag to hash based structure.
Adds extension point to inject custom JSON converters to the JSON serialization settings.