Source link #17
Merged
Source link #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Kritner
commented
Nov 28, 2021
Kritner
commented
- Added Microsoft.SourceLink.GitHub from https://github.com/dotnet/sourcelink
- Reduced the Orleans dependencies to 3.1.0 as the minimum version
- Introduces new assembly to hold grains. Rather than defining them directly in Orleans.SyncWork.Demo.Api, they are now defined in Orleans.SyncWork.Demo.Services
- Not quite sure what to do here yet, I've not done multi targeting before, but that's (I think?) the route I wanted to take. My unease comes from the fact that different versions of Orleans depend on different versions of the framework. Since the Orleans.SyncWork csproj file defines a lower bound, but no upper bound, I'm guessing this works? Will need to do some testing.
- Updates CI to do multi platform testing
- Updates CICD to continue running on release branch, but can optionally be triggered manually.
* Added Microsoft.SourceLink.GitHub from https://github.com/dotnet/sourcelink * Reduced the Orleans dependencies to 2.1.0 as the minimum version
* Introduces new assembly to hold grains. Rather than defining them directly in Orleans.SyncWork.Demo.Api, they are now defined in Orleans.SyncWork.Demo.Services * Not quite sure what to do here yet, I've not done multi targeting before, but that's (I think?) the route I wanted to take. My unease comes from the fact that different versions of Orleans depend on different versions of the framework. Since the Orleans.SyncWork csproj file defines a lower bound, but no upper bound, I'm *guessing* this works? Will need to do some testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.