Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new ISiloBuilder extension method #34

Merged

Conversation

Kritner
Copy link
Member

@Kritner Kritner commented Jan 7, 2022

Description

Adds new ISiloBuilder extension method that can be used with the UseOrleans extension method on top of IHostBuilder

Fixes #33

Type of Change

  • Bug fix
  • New Feature
  • Documentation
  • Code improvement
  • Breaking change - if a public API changes, or any change that DOES or MAY require a major revision to the NuGet package version due to semver.
  • Unit tests
  • Code samples
  • Added your repository URL to the readme because you make use of this super cool package! ;)
  • Other

Describe testing that was performed for your change

Added new unit tests mirroring the tests against ISiloHostBuilders extension methods

Checklist

@Kritner Kritner merged commit c204bc1 into OrleansContrib:main Jan 7, 2022
@Kritner Kritner deleted the FEATURE/siloHostBuilderExtension_33 branch January 7, 2022 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce "bootstrapping" extension method for ISiloBuilder, like the one existing for ISiloHostBuilder
1 participant